fix(progress): consistent vertical spacing in empty state (BLD-4569) - #925
Open
alankyshum wants to merge 3 commits into
Open
fix(progress): consistent vertical spacing in empty state (BLD-4569)#925alankyshum wants to merge 3 commits into
alankyshum wants to merge 3 commits into
Conversation
… (BLD-4548) - overflowBtn top: 4→6, right: 4→6 in FormLibraryTab.tsx - Aligns with sibling checkOverlay which already uses top/right: 6 - Also removes stale marginTop: 4 from the preceding rule Co-Authored-By: Paperclip <noreply@paperclip.ing>
- Replace hard-coded margin values with spacing tokens from design-tokens - Remove iconCircle.marginBottom: 4 that was adding extra gap after icon - Remove cta.marginTop: 8 that was breaking the uniform gap rhythm - Add marginTop: -spacing.sm on description to tighten headline↔paragraph pair - Update paddingHorizontal/paddingVertical/gap to use spacing tokens - Add testID='progress-empty-icon-circle' for headless verification - Add tests covering consistent vertical spacing and text pair cohesion Resolves BLD-4569 (source: BLD-4528) Co-Authored-By: Paperclip <noreply@paperclip.ing>
alankyshum
force-pushed
the
fix/bld-4569-progress-empty-state-spacing
branch
from
July 28, 2026 15:50
c33cf13 to
2767f61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inconsistent vertical spacing in the progress-tab empty state component (
WorkoutEmptyState.tsx).Source: UX audit [BLD-4528] flagged uneven gaps (12/16/20px) caused by ad-hoc margin overrides on top of a uniform
gap: 12container.Changes
iconCircle.marginBottom: 4— was adding an extra 4px gap after the icon, making icon→headline gap effectively 16pxcta.marginTop: 8— was making description→CTA gap effectively 20px, breaking rhythmmarginTop: -spacing.smon description to tighten headline↔paragraph pair for visual cohesionpaddingHorizontal: 32,paddingVertical: 24,gap: 12) with spacing tokenstestID='progress-empty-icon-circle'for headless AC verificationTests
New tests in
__tests__/components/progress/WorkoutEmptyState.test.tsx:iconCircle.marginBottomis undefined (no ad-hoc extra gap)cta.marginTopis undefined (no ad-hoc extra gap)description.marginTopequals-spacing.sm(tightened headline↔description)Closes BLD-4569