fix(settings): remove double top-spacing on About section header (BLD-4579) - #930
Draft
alankyshum wants to merge 1 commit into
Draft
fix(settings): remove double top-spacing on About section header (BLD-4579)#930alankyshum wants to merge 1 commit into
alankyshum wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the 'About' tile header in Settings having double the expected top-spacing gap compared to every other Settings section.
Root cause
already applies below its title. The first row inside the About tile — — also applied , adding an extra on top. This doubled the header-to-content gap to
2 × spacing.sm.Fix
Changed
versionRowfrompaddingVertical: spacing.smtopaddingBottom: spacing.sm, removing the top padding entirely. The SettingsTile title margin already provides the correct single-spacing.smgap. Touch target height (minHeight: 48) is unchanged.Files changed:
app/(tabs)/settings.tsx— style fix onversionRow__tests__/acceptance/settings.test.tsx— regression test assertingpaddingTop === 0,paddingBottom === spacing.sm, andminHeight >= 48CHANGELOG.md— Unreleased entryVerification
tsc --noEmit: zero errorsjest __tests__/acceptance/settings.test.tsx: 22/22 pass (including new BLD-4579 test)Resolves BLD-4579