Add Support of PageToken while requesting comments#188
Open
artin1982 wants to merge 3 commits intoalaouy:masterfrom
Open
Add Support of PageToken while requesting comments#188artin1982 wants to merge 3 commits intoalaouy:masterfrom
artin1982 wants to merge 3 commits intoalaouy:masterfrom
Conversation
Add Support of PageToken while requesting comments
alaouy
requested changes
May 17, 2023
| * @throws \Exception | ||
| */ | ||
| public function getCommentThreadsByVideoId($videoId = null, $maxResults = 20, $order = null, $part = ['id', 'replies', 'snippet'], $pageInfo = false) { | ||
| public function getCommentThreadsByVideoId($videoId = null, $maxResults = 20, $order = null, $part = ['id', 'replies', 'snippet'], $pageInfo = false), $pageToken = null { |
Owner
There was a problem hiding this comment.
Typo?
Suggested change
| public function getCommentThreadsByVideoId($videoId = null, $maxResults = 20, $order = null, $part = ['id', 'replies', 'snippet'], $pageInfo = false), $pageToken = null { | |
| public function getCommentThreadsByVideoId($videoId = null, $maxResults = 20, $order = null, $part = ['id', 'replies', 'snippet'], $pageInfo = false, $pageToken = null){ |
| * @throws \Exception | ||
| */ | ||
| public function getCommentThreads($channelId = null, $id = null, $videoId = null, $maxResults = 20, $order = null, $part = ['id', 'replies', 'snippet'], $pageInfo = false) | ||
| public function getCommentThreads($channelId = null, $id = null, $videoId = null, $maxResults = 20, $order = null, $part = ['id', 'replies', 'snippet'], $pageInfo = false, $pageToken = null) |
Owner
There was a problem hiding this comment.
Looks good to me, just please update the tests accordingly
Owner
There was a problem hiding this comment.
@artin1982 I see this was fixed, can you also please update the tests accordingly in order to merge it for the next release ?
my fault 🤦♂️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Support of PageToken while requesting comments.
So We can paginate comments ... :)