Treat empty nullable CSV fields as NULL during sync - #78
Merged
Merged
Conversation
Co-authored-by: alastairtree <6273429+alastairtree@users.noreply.github.com>
Co-authored-by: alastairtree <6273429+alastairtree@users.noreply.github.com>
Copilot
AI
changed the title
Fix nullable empty CSV values syncing as empty strings
Treat empty nullable CSV fields as NULL during sync
Sep 15, 2026
Copilot created this pull request from a session on behalf of
alastairtree
September 15, 2026 09:45
View session
alastairtree
approved these changes
Sep 15, 2026
alastairtree
marked this pull request as ready for review
September 15, 2026 09:52
alastairtree
enabled auto-merge (squash)
September 15, 2026 09:52
Contributor
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 88.00% 88.03% +0.03%
==========================================
Files 17 17
Lines 2759 2759
==========================================
+ Hits 2428 2429 +1
+ Misses 331 330 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty CSV cells in nullable typed columns were not handled consistently: SQLite stored
"", while PostgreSQL rejected numeric empties before they could becomeNULL. This updates sync behavior sonullable: trueis sufficient on its own andlookup: { "": null }is no longer required for ordinary empty-field handling.Behavior change
NULLfor nullable columns after lookup processingLookup interaction
NULLwhen the final transformed value is still empty, so non-empty replacements fromlookupcontinue to work as beforeRegression coverage
Versioning
0.7.0to0.7.1With this change, an empty
densityfield in the CSV now syncs as databaseNULLwithout requiring: