Introduce haptic feedback - #99
Open
esai256 wants to merge 4 commits into
Open
Conversation
Owner
|
I think the feature makes sense and the code looks good. Since we don't have any other "behavior" settings, I would maybe change the strings so that "Haptic feedack" is the title and add a simple description like "Vibrate when changing a counter" as the text next to the toggle (also because not everybody knows what haptic means). I haven't been able to try the app with the change yet, but will do so after the holidays :) I didn't think about knitting as a use case for the app, I'm happy it helps for that 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I added a setting to enable haptic feedback every time you increased or decreased a counter.
Context
I use the BetterCounter for knitting, more specifically for counting my rows. It happened to me some times, that I pressed too long, or moved away from the button, so the button did not actually trigger without me noticing.
Then, when I noticed, that I sometimes missed it, I became paranoid about whether I pressed. Increasing a row sometimes happens within a minute, so sadly the time display alone won't help.
Having haptic confirmation would help me a lot, I think.
Changes
Disclaimer
I am not confident in Java and/or Kotlin, so if I'm missing conventions, I'm happy to learn.
No code was AI-generated*, so all mistakes belong to me.
*Translations aside from German and English were made by ChatGPT.