Skip to content

Introduce haptic feedback - #99

Open
esai256 wants to merge 4 commits into
albertvaka:mainfrom
esai256:feat/introduce-haptic-feedback
Open

Introduce haptic feedback#99
esai256 wants to merge 4 commits into
albertvaka:mainfrom
esai256:feat/introduce-haptic-feedback

Conversation

@esai256

@esai256 esai256 commented Dec 28, 2025

Copy link
Copy Markdown

Hi!
I added a setting to enable haptic feedback every time you increased or decreased a counter.

Context

I use the BetterCounter for knitting, more specifically for counting my rows. It happened to me some times, that I pressed too long, or moved away from the button, so the button did not actually trigger without me noticing.
Then, when I noticed, that I sometimes missed it, I became paranoid about whether I pressed. Increasing a row sometimes happens within a minute, so sadly the time display alone won't help.
Having haptic confirmation would help me a lot, I think.

Changes

  • I added an entry "isHapticFeedbackEnabled" to the Repository to store the setting.
  • I addded the respective switch to the settings activity in a new section "Behavior".
  • The switch default setting is "off", therefore the default behavior doesn't change.
  • I added the haptic feedback in the EntryViewHolder. I'm unsure, whether this is the right place, as most logic happens in the MainActivity, but felt this was more UI-related and therefore it might be good here.

Disclaimer

I am not confident in Java and/or Kotlin, so if I'm missing conventions, I'm happy to learn.
No code was AI-generated*, so all mistakes belong to me.

*Translations aside from German and English were made by ChatGPT.

@albertvaka

albertvaka commented Dec 29, 2025

Copy link
Copy Markdown
Owner

I think the feature makes sense and the code looks good.

Since we don't have any other "behavior" settings, I would maybe change the strings so that "Haptic feedack" is the title and add a simple description like "Vibrate when changing a counter" as the text next to the toggle (also because not everybody knows what haptic means).

I haven't been able to try the app with the change yet, but will do so after the holidays :)

I didn't think about knitting as a use case for the app, I'm happy it helps for that 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants