Fix video spill colour selection and secondary casts (v2.5.2) - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video spill correction could treat warm material as key-coloured material and leave reflections untreated. Full correction could then amplify small colour differences into a secondary cast.
This patch uses key-hue evidence for automatic selection and bounded colour recovery for full correction, preserving alpha and the conservative mode. It also updates the package and skill to v2.5.2. Source colours outside the key hue remain unchanged.
Validation: 1,763 tests passed (one skipped), including synthetic colour-preservation and imperfect-key regressions. All 239 package checks passed after refreshing stale editable metadata. The installed wheel was exercised through both video-frames and video-loop.