v2.5.4: room behind the attack canvas, --base direction check - #53
Merged
Merged
Conversation
An undocumented key such as left= was accepted and then animated with the default facing, so the caller's intent was inverted without a word. The parser now names the allowed directions (back, front, side) and refuses the rest.
…ample The scrub rule matches the _MEMBER_ID suffix, so the sample name carries no meaning; the old one named a private tool.
A long weapon drawn back before the strike reached the back edge of the wide layout, which placed every spare pixel in front, and the frames gate refused the clip. The attack profile now keeps 20 % of the width empty behind the subject (--trail, next to --lead); headroom and the other profiles are unchanged and --trail 0 restores the old placement. Measured on the two stills that needed hand-padding in v2.5.3: the samurai passes first try (seam 1.19) and the katana passes after one regeneration (seam 1.63), both from the raw still.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--trail, next to--lead). A long weapon drawn back reached the back edge of the old layout and the frames gate refused the clip; the two stills that needed hand-padding in v2.5.3 now pass from the raw still (samurai first try, katana after one regeneration). Ten-character regression: 10/10 first try.video-set --baserefuses a direction the prompt table does not know instead of acceptingleft=and animating with the default facing.Full suite: 1867 passed, 3 skipped. Release commit bumps 2.5.4; tag and release page follow the merge.