v2.5.5: refuse a lone step under the gait floor - #55
Merged
Merged
Conversation
…ooping half a stride When the deepest repeat sat under the gait floor and nothing near twice it repeated about as well, the selector recorded that the double was worse and then kept the step anyway. A quadruped whose near and far legs read alike produces exactly that profile, so its walk looped half a stride without a word (measured on a production cat clip: 12 frames under a 14-frame floor, best double 22 at 1.37x worse). Now the double is looked for among the profile's own minima within three frames of 2p, since a real stride rarely lands on exactly 2p, and when none repeats within GAIT_DOUBLE_TOL the selector refuses under the same words as a flat profile, so a caller's regenerate-on-no-period rule covers both. The failure report carries the guard and the minima it weighed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
video-looprefuses withno periodic cycle foundinstead of looping half a stride; the failure report carries the guard's verdict and the minima it weighed. The doubled period is searched among the profile's own minima within three frames of twice the step.Release commit bumps 2.5.5. The tag push lets the release workflow create the page.