Allow more year usage variations #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous approach allowed only specific patterns to be used together with a separate year pattern. This limited scope for tests and prevented valid, yet invalid, cases like
2023 April 1st 2024from being used.Now when a separate year is set, we disllow use of any patterns that can contain another explicit year - dateimes, timestamps etc.
Without sorting the calls, year is not longer guaranteed to be processed first, and thus it needs to be handed in with the first date modification. Otherwise leap day and weekday validations can cause issues.
To use the default year only once,
FuzzyDatenow carries the default value until the date is altered once ... this probably needs be turned into a self-consuming chain later.End result is that more previously unhandled variations are allowed, for exaple: