app working - #5
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a small Flask HTTP API endpoint that combines flight lookup and location-based news retrieval, plus adds local-development editor configuration and expands Python-related ignores.
Changes:
- Added
app.pyFlask app with/flight/<flight_number>/newsendpoint that orchestratesservices.flightandservices.news. - Added
.vscode/settings.jsonto load.envinto the Python terminal/debug environment. - Expanded
.gitignoreto ignore common Python artifacts and logs (and keeps.envignored).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| app.py | New Flask route that fetches flight destination and returns related news articles as JSON. |
| .vscode/settings.json | Configures VS Code to use .env for Python environment variables. |
| .gitignore | Adds standard Python cache/bytecode/log ignores and keeps .env ignored. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+13
to
+15
| try: | ||
| destination = get_destination_from_flight(flight_number) | ||
| except RequestException: |
Comment on lines
+27
to
+28
| if not destination.get("success"): | ||
| return jsonify({"success": False, "stage": "flight", **destination}), 404 |
Comment on lines
+30
to
+32
| try: | ||
| headlines = get_headlines_for_location(destination["lat"], destination["lon"]) | ||
| except RequestException: |
Comment on lines
+44
to
+45
| if not headlines.get("success"): | ||
| return jsonify({"success": False, "stage": "news", **headlines}), 502 |
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| app.run(debug=True) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.