Fix missing Mapbox preview and route URL on duplicate GPX upload#30
Draft
Fix missing Mapbox preview and route URL on duplicate GPX upload#30
Conversation
✅ Deploy Preview for trainpace ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…oute URL When a duplicate GPX file is detected and the user clicks "Use Existing File", the fetchExistingFileContent function now passes displayPoints to onFileParsed for Methods 1 (Firestore cache) and 2 (Storage reference). This ensures the Mapbox route preview renders and the route URL is properly generated. Changes: - Added displayPoints to DuplicateFile interface - Read displayPoints from Firestore document in checkForDuplicate - Pass displayPoints in Method 1 (Firestore cache) - Pass displayPoints in Method 2 (Storage ref) with processGPXUpload fallback Co-authored-by: aleexwong <65264501+aleexwong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix gpx upload issue with mapbox review
Fix missing Mapbox preview and route URL on duplicate GPX upload
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Duplicate GPX uploads via "Use Existing File" never rendered the map preview or route URL because
fetchExistingFileContentomitteddisplayPointsfrom theonFileParsedcallback in the two primary code paths.displayPointstoDuplicateFileinterface and read it from the Firestore document incheckForDuplicatedisplayPointsthroughonFileParsedin Method 1 (Firestore content cache) and Method 2 (Storage reference fetch), with aprocessGPXUpload()fallback for Method 2 if cached points are missingThe fresh upload path already passed all required args correctly — only the duplicate resolution paths were affected:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.