Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades samples and CI to .NET 9.0, removes the obsolete .NET Core 3.1 sample, and refreshes documentation and tests for consistency.
- Deleted the entire SampleWebApplication3_1 project and its integration tests
- Enhanced 2.1 integration tests to use TestHost and a solution‐relative content root
- Updated GitHub Actions workflow to use .NET 9.0, the new solution file, and latest action versions
- Added alt text and a support note to README
Reviewed Changes
Copilot reviewed 35 out of 45 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/3.1/SampleWebApplication3_1/Startup.cs | Removed old ASP.NET Core 3.1 startup code |
| samples/3.1/SampleWebApplication3_1/Program.cs | Removed obsolete WebHost setup |
| samples/3.1/SampleWebApplication3_1.IntegrationTests/*.cs | Deleted all 3.1 integration tests |
| samples/2.1/SampleWebApplication2_1.IntegrationTests/LoggingTestWithInjectedFactory.cs | Added Microsoft.AspNetCore.TestHost and solution‐relative root |
| samples/2.1/SampleWebApplication2_1.IntegrationTests/LoggingTest.cs | Added UseSolutionRelativeContentRoot for reliable content path |
| README.md | Added alt text, bolded star, and support note |
| .github/workflows/build.yml | Upgraded to checkout@v4, setup-dotnet@v4, target .NET 9.0, use .CI.slnf |
Files not reviewed (10)
- Directory.Build.props: Language not supported
- MELT.CI.slnf: Language not supported
- MELT.sln: Language not supported
- samples/2.1/SampleWebApplication2_1.IntegrationTests/SampleWebApplication2_1.IntegrationTests.csproj: Language not supported
- samples/2.1/SampleWebApplication2_1/SampleWebApplication2_1.csproj: Language not supported
- samples/3.1/SampleWebApplication3_1.IntegrationTests/Properties/launchSettings.json: Language not supported
- samples/3.1/SampleWebApplication3_1.IntegrationTests/SampleWebApplication3_1.IntegrationTests.csproj: Language not supported
- samples/3.1/SampleWebApplication3_1/Properties/launchSettings.json: Language not supported
- samples/3.1/SampleWebApplication3_1/SampleWebApplication3_1.csproj: Language not supported
- samples/3.1/SampleWebApplication3_1/appsettings.Development.json: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced May 18, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.