Repository navigation
Analítica: canal de la primera visita en eventos de conversión - #334
alejooroncoy wants to merge 3 commits into
Conversation
… eventos de conversión Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…encia con pruebas Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3208de6d93
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // A tab opened before this feature, or cleared storage, must still record the first entry. | ||
| try { saveFirstEntry(JSON.parse(decodeURIComponent(previous.value)), now); } catch { /* Optional. */ } | ||
| return; |
There was a problem hiding this comment.
When a visitor first opens the site directly and subsequently follows a campaign or MCP link in the same tab within 24 hours, this branch re-saves the cached direct entry and returns before inspecting the new URL or referrer. Consequently, saveFirstEntry never receives the real channel, and conversion events remain attributed to direct despite the intended replacement behavior. Calling rememberEntry first for / and then for /?utm_source=facebook&utm_campaign=123456789 with the same session storage reproduces this. Evaluate the current entry before this early return, at least when the saved first channel is direct; the new tests miss this because visit() replaces session storage by default.
Useful? React with 👍 / 👎.
Guarda en localStorage el primer canal observado (primera visita gana, respeta la baja), añade entry_landing a la cookie de OAuth y adjunta entry_* a los eventos de acceso/checkout de Plus y Turnitin, con allowlist en el contrato. Documenta por qué hay logins sin pageview y una consulta HogQL por canal.
Pendiente fuera de este repo: que campus-profes copie entry_landing en campus_auth_completed. Probado: test:analytics, test:analytics:transport (SDK real con red interceptada), astro check. Un login local no envía eventos (modo debug), la verificación es la prueba de transporte.
@codex review
🤖 Generated with Claude Code