Домашка#1
Open
aleksLegat wants to merge 1 commit into
Open
Conversation
| return newItem; | ||
| } | ||
| } | ||
| // static class ListDiffCallback extends DiffUtil.ItemCallback<FilterContactTypeUi> { |
There was a problem hiding this comment.
Закоментированный код лучше сразу удалять. Хранить закоментированный код в проекте - плохая практика, в случае чего этот код можно восстановить с помощью истории гита
| } | ||
|
|
||
| @Override | ||
| public boolean theSameAs(ContactUi item) { |
There was a problem hiding this comment.
В подобных функциях сравнения, где в качестве аргумента функции принимается объект того же класса для сравнения с текущим объектом, принято называть аргумент как other для повышения читабельности кода
Owner
Author
There was a problem hiding this comment.
Спасибо! Долго думал как назвать, чтобы было понятно, остановился на нейтральном item, но other гораздо более говорящее имя переменной в данном случае.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.