train_for_seconds flag not being tracked#330
Merged
Merged
Conversation
Owner
|
Hi @lmBored ! Sorry for the delay |
Contributor
Author
|
Hi! Thank you for your response! It was such a small fix, so I thought it would be better to integrate with a larger PR so you don't need to approve twice:) But Im glad you are here! I will reopen the PR |
Contributor
Author
|
oh I forgot this branch is still a PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small PR, previously
train_for_secondsflag was not being tracked (astotal_train_secondswas not calculated), and as a result training didn't stop as set bytrain_for_seconds.I believe this was a minor overlook, thus I didn't open an issue but open a PR directly.