Patch timezone offset handling for UTC#37
Open
dtflowers wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was first identified here: #7 and was partially patched in this commit: d06a5dc
Currently, however, if you pass
0as an integer as the timezone_offset to try to standardize for UTC, the validation still fails to accept it because, as mentioned in the thread above, 0 is falsy and thus, the checkInt validation fails. (This line: https://github.com/alexfedoseev/sourcebuster-js/blob/master/src/js/params.js#L107)This PR should at least be on the right track towards patching this, it seems to work for us.