Skip to content

Enforce the house style and script the release tag - #7

Merged
alexander-wang03 merged 3 commits into
masterfrom
release-checks
Sep 12, 2026
Merged

alexander-wang03 merged 3 commits into
masterfrom
release-checks

Conversation

@alexander-wang03

Copy link
Copy Markdown
Owner

What this changes

Turns three lessons from the 0.3 cycle into checks: tools/check_style.py fails CI on em-dashes and the six banned words, tools/release_check.py fails when emet-hal's README does not name every entry point the package registers, and tools/tag_release.py makes the signed release tag after refusing a dirty tree, the wrong branch, a version the packages do not declare, or a missing signing key. CONTRIBUTING.md and RELEASING.md describe them.

Why

Each check replaces a rule a person kept missing: 178 em-dashes passed review over three releases, the HAL README shipped 0.3 naming four of eleven plugins, and v0.3 first went up as an unsigned tag. A rule a person applies gets skipped; a check does not.


Checklist

  • Commits are signed off (git commit -s). See CONTRIBUTING.md.
  • python tools/check_layering.py . and python tools/release_check.py . pass.
  • pytest passes in emet-sdk, emet-hal and emet-engine.
  • New behaviour has a test and a caller.
  • Anything taken from a paper or repository is cited at the point of use and in CITATIONS.md.

If this touches the contract layer

Leave blank: it does not.

  • This was discussed in an issue first.
  • Existing manifests and soul bundles still validate.
  • New schema fields are tagged P0, RSV, or V1 in DESIGN.md.

Design rules

  • The soul names no hardware.
  • Every fallback chain still terminates in a voice rung.
  • emet_sdk imports nothing internal; emet_hal and emet_engine import emet_sdk only.
  • Memory is not namespaced by body.
  • A missing plugin is still distinct from a schema error.

Signed-off-by: Alexander Wang <87671725+alexander-wang03@users.noreply.github.com>
Signed-off-by: Alexander Wang <87671725+alexander-wang03@users.noreply.github.com>
Signed-off-by: Alexander Wang <87671725+alexander-wang03@users.noreply.github.com>
@alexander-wang03
alexander-wang03 merged commit 9a404a8 into master Sep 12, 2026
9 checks passed
@alexander-wang03
alexander-wang03 deleted the release-checks branch September 12, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant