Filter resolution candidates by both interface and concrete type. - #109
Merged
Conversation
- Filter candidates by concrete type in addition to interface type in `Locator`, so a binding specifying both an interface and a concrete type resolves the concrete type instead of the first interface match - Extract type and dependency filtering into a shared `GetTypeAndDependencyFilteredCandidates` method used by both component and asset resolution - Rename `ApplyTypeAndDependencyFilters` and `ApplyContextFilters` to `GetTypeAndDependencyFilteredCandidates` and `GetContextFilteredCandidates` - Add `SecondComponentDependency` fixture (a second `IDependency` implementer) to support multi-implementer resolution tests - Add `InterfaceConcreteResolutionTests` regression test covering interface plus concrete component bindings when multiple interface implementers exist - Bump package version to 1.2.1 and add changelog notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locator, so a binding specifying both an interface and a concrete type resolves the concrete type instead of the first interface matchGetTypeAndDependencyFilteredCandidatesmethod used by both component and asset resolutionApplyTypeAndDependencyFiltersandApplyContextFilterstoGetTypeAndDependencyFilteredCandidatesandGetContextFilteredCandidatesSecondComponentDependencyfixture (a secondIDependencyimplementer) to support multi-implementer resolution testsInterfaceConcreteResolutionTestsregression test covering interface plus concrete component bindings when multiple interface implementers exist