fix: keep Chrome in MDB and isolate live bridge from tests - #9
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #8. Separates approval strictness from Chrome routing and fixes the test-isolation bug that was revoking the live menu-bar bridge unlock after
npm test.Always route Chrome through MDB
CHROME_BACKGROUND_REQUIREDin both Relaxed and Strict modesopenof HTTP/HTTPS URLs is rejected even withopen -g, so agent browser tabs cannot bypass the managedMDBgroupshell_execandshell_startenforce the ruleThis addresses a live regression where another concurrent Mato/Syften workflow bypassed the extension with Chrome AppleScript, created ungrouped tabs, and repeatedly stole foreground focus. After the guard was loaded, that workflow switched to Syften API/feed access instead.
Stop tests from taking down the live bridge
tests/installer-mock.shnow explicitly overridesMAC_DEV_BRIDGE_UNLOCK_FILE; previously it inherited the real menu-bar unlock path and mockuninstall.shremoved itdisable.shcoverage now uses a temporary fake install directory, preventing fallback process scans from matching the live repo checkoutnpm testrun leaves both the live unlock file and live bridge PID intactPreserve contributor checksum contract
SHA256SUMSafter feat: background Chrome workspace with relaxed approvals #8Validation
npm test— full suite greenFULL_ACCESS_ENABLEDremained present after the full suitenode tests/smoke.mjsnode tests/chrome-background.mjsnpm run checkswiftc -typecheck -target "$(uname -m)-apple-macos13.0" -framework AppKit menubar/MenuBarApp.swiftnpm pack --dry-run --jsonshasum -a 256 -c SHA256SUMS— all entries OKgit diff --checkCHROME_BACKGROUND_REQUIRED