Fix broken CSS cache busting - #5
Merged
Merged
Conversation
bust_css_cache hashed the non-existent assets/_sass directory, always yielding md5 of the empty string, so browsers never picked up new CSS after deploys. Override the filter to hash _sass/ and assets/css/. Co-authored-by: Cursor <cursoragent@cursor.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main.csswas always served with?v=d41d8cd98f00b204e9800998ecf8427e(the md5 of an empty string) because thebust_css_cachefilter from jekyll-cache-bust hashesassets/_sass/, which does not exist in this repo (Sass lives in_sass/)_sass/**/*.scss,assets/css/**/*.scss, and_config.yml, so the version changes whenever styles changeTest plan
main.css?v=now carries a real content hashMade with Cursor