Skip to content

Fix high resolution streams #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeichhorn merged 1 commit into from
Jun 12, 2026
Merged

Fix high resolution streams #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@
},
"dependencies": {
"quickjs-emscripten": "^0.31.0",
"youtubei.js": "github:alexeichhorn/YouTube.js#feat/android-sdkless-client"
"youtubei.js": "github:alexeichhorn/YouTube.js#4f74d89a"
}
}
17 changes: 14 additions & 3 deletions src/youtube/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,18 +261,29 @@ export class YouTubeService {
}
}

// TODO: remove duplicate itags
// TODO: parallelize it

if (allStreams.length === 0) {
try {
return await this.getStreamsForClient(innertube, fallbackClient);
return this.deduplicateStreams(await this.getStreamsForClient(innertube, fallbackClient));
} catch (error) {
console.error(`Failed to get streams for fallback client ${fallbackClient}:`, error);
}
}

return allStreams;
return this.deduplicateStreams(allStreams);
}

private deduplicateStreams(streams: RemoteStream[]): RemoteStream[] {
const streamsByItag = new Map<number, RemoteStream>();

for (const stream of streams) {
if (!streamsByItag.has(stream.itag)) {
streamsByItag.set(stream.itag, stream);
}
}

return Array.from(streamsByItag.values());
}

private async getStreamsForClient(innertube: Innertube, client: AvailableInnertubeClient): Promise<RemoteStream[]> {
Expand Down
Loading