Skip to content

Include stream dimensions - #9

Merged
alexeichhorn merged 1 commit into
cloudflare-workerfrom
fix/stream-dimensions
Aug 19, 2026
Merged

alexeichhorn merged 1 commit into
cloudflare-workerfrom
fix/stream-dimensions

Conversation

@alexeichhorn

@alexeichhorn alexeichhorn commented Aug 19, 2026

Copy link
Copy Markdown
Owner
  • Problem: Remote stream responses omit video dimensions, so YouTubeKit cannot declare accurate HLS variant resolutions from server-fetched metadata.
  • Solution: Carry optional format width and height values into RemoteStream, preserving audio-only and dimensionless formats. Closes Include stream dimensions in RemoteStream responses #8.

Note

Overview This PR extends stream metadata with video dimensions.

Stream dimensions RemoteStream now includes optional width and height fields, populated from each source format when stream responses are assembled.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
youtubekit-server 0c5ef8b Aug 19 2026, 08:50 AM

@alexeichhorn
alexeichhorn marked this pull request as ready for review August 19, 2026 09:12
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7cb0f8c5-97e9-473e-9c22-1e06a92c7321

📥 Commits

Reviewing files that changed from the base of the PR and between b6fb48d and 0c5ef8b.

📒 Files selected for processing (2)
  • src/youtube/models/websocket.ts
  • src/youtube/service.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

RemoteStream now exposes optional width and height fields. getStreamsForClient() copies these values from each YouTube format.

Changes

Remote stream dimensions

Layer / File(s) Summary
Stream metadata contract and mapping
src/youtube/models/websocket.ts, src/youtube/service.ts
RemoteStream adds optional numeric dimensions. Generated streams copy width and height from the corresponding YouTube format.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 0c5ef

The PR adds optional video width and height metadata while preserving audio-only and dimensionless formats; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the addition of stream dimensions.
Description check ✅ Passed The description accurately explains the problem, solution, and supported audio-only and dimensionless formats.
Linked Issues check ✅ Passed The changes add optional dimensions to RemoteStream and populate them from YouTube formats as required by issue #8.
Out of Scope Changes check ✅ Passed The changes are limited to adding and populating stream dimension fields required by issue #8.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/stream-dimensions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alexeichhorn
alexeichhorn merged commit b4bee80 into cloudflare-worker Aug 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include stream dimensions in RemoteStream responses

1 participant