Skip to content

Run builds for pull requests - #138

Merged
alexeichhorn merged 1 commit into
mainfrom
ci/run-builds-on-pull-requests
Aug 6, 2026
Merged

alexeichhorn merged 1 commit into
mainfrom
ci/run-builds-on-pull-requests

Conversation

@alexeichhorn

@alexeichhorn alexeichhorn commented Aug 5, 2026

Copy link
Copy Markdown
Owner
  • Problem: The Swift build matrix only runs for pushes to this repository, so pull requests from forks can appear ready to merge without compiling.
  • Solution: Run the matrix for pull requests targeting main and limit push builds to main. The existing first-time-contributor approval policy keeps external workflow runs behind maintainer approval.

Note

Overview

Pull request builds. Extends the Swift unit test workflow to run for pull requests targeting main, adding CI coverage before changes are merged.

Push scope. Restricts the existing push trigger to main, preserving builds for changes landing on the primary branch.

@alexeichhorn
alexeichhorn marked this pull request as ready for review August 6, 2026 08:14
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e3ff0472-585c-4bb7-8d41-0dbe4fb173ab

📥 Commits

Reviewing files that changed from the base of the PR and between 7cc8190 and d8671c6.

📒 Files selected for processing (1)
  • .github/workflows/swift.yml

📝 Walkthrough

Walkthrough

The Swift GitHub Actions workflow now runs for pushes to main and pull requests targeting main.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the primary change: running builds for pull requests.
Description check ✅ Passed The description accurately explains the workflow changes and their purpose.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/run-builds-on-pull-requests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alexeichhorn
alexeichhorn merged commit 06164d5 into main Aug 6, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant