Skip to content

atf_comp script generation rework#115

Merged
ali5h merged 2 commits into
alexeilebedev:masterfrom
ali5h:ali-patch-jan-2026
Mar 7, 2026
Merged

atf_comp script generation rework#115
ali5h merged 2 commits into
alexeilebedev:masterfrom
ali5h:ali-patch-jan-2026

Conversation

@ali5h

@ali5h ali5h commented Feb 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Rework script pipeline: capture raw output to .out.raw, then run filter to produce .out
  • Separate raw input: write tmsgs to .in.raw via heredoc, then run ifilter to produce .in
  • Move filter execution into the generated script (previously ran in CompareOutput C++ code)
  • Add set -eu -o pipefail to generated test scripts for stricter error handling

New command-line options

  • Add -tempdir and -testdir options to make temp/test directories configurable

Replscope and variable fixes

  • Restore missing $$ and $timeout variables in Replscope setup
  • Fix $compdir -> $bindir rename in script export
  • Add new exported variables: $in_raw, $out_raw, $finput, $foutput

New component tests

  • atf_comp.Smoke: self-test running atf_comp against a trivial cat command with ifilter (sort) and tfilt (sort -r)
  • atf_exp.AcrInteractive: sample interactive test feeding a record to acr -in:- and verifying the response

Coverage improvements

  • atf_comp: 0% -> 43.19%
  • atf_exp: 0% -> 71.37%

- Restore missing $$ and $timeout variables in Replscope setup
- Fix $compdir -> $bindir rename in script export
- Fix stale -compdir reference in README
- Add atf_exp.AcrInteractive: sample interactive test feeding
  a record to acr -in:- and verifying the response
@ali5h ali5h changed the title atf_comp: restore missing variables, add atf_exp sample test comptest for atf_comp and atf_exp Feb 23, 2026
@ali5h ali5h changed the title comptest for atf_comp and atf_exp atf_comp script generation rework Feb 23, 2026
@ali5h ali5h merged commit f32d4ef into alexeilebedev:master Mar 7, 2026
5 checks passed
@ali5h ali5h deleted the ali-patch-jan-2026 branch March 7, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants