Restructure atf_comp, retire atf_exp#120
Merged
Merged
Conversation
Split monolithic `cpp/atf_comp/main.cpp` into one file per subcommand (`atf_comp.cpp`, `proc.cpp`, `acr.cpp`, `acr_compl.cpp`, `aqlite.cpp`, `sandbox.cpp`, etc). Dispatch replaces hand-written mode switches. Retire `atf_exp` - its role is covered by the new atf_comp and acr_compl tests. Schema: add `atfdb.unstableattr` (comptest output filter for values that legitimately vary between runs); drop obsolete `targs`, `tmsg`, `tifilt`, most `tfilt`. Expand `dmmeta.userfunc` to back the new dispatch. All ~280 affected comptest outputs recaptured.
alexeilebedev
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split monolithic
cpp/atf_comp/main.cppinto one file per subcommand (atf_comp.cpp,proc.cpp,acr.cpp,acr_compl.cpp,aqlite.cpp,sandbox.cpp, etc). Dispatch replaces hand-written mode switches.Retire
atf_exp- its role is covered by the new atf_comp and acr_compl tests.Schema: add
atfdb.unstableattr(comptest output filter for values that legitimately vary between runs); drop obsoletetargs,tmsg,tifilt, mosttfilt. Expanddmmeta.userfuncto back the new dispatch.All ~280 affected comptest outputs recaptured.