Add search and cycle filters (/ / f / F)#6
Merged
Conversation
PinPadViewFilter combines today, text query, done state, and priority. Adds cycle helpers, filter_active, and title suffix builder. Tests cover all filter dimensions and cycle order. Co-authored-by: Cursor <cursoragent@cursor.com>
/ prompts for a case-insensitive text filter; f cycles all/pending/done; F cycles all/high/medium/low. Composable with T (today). Title and empty state reflect active filters; reset on close. Co-authored-by: Cursor <cursoragent@cursor.com>
README features, config, mappings; SPEC filter model and key table. Co-authored-by: Cursor <cursoragent@cursor.com>
alexesba
force-pushed
the
feature/search-filter
branch
from
be6da3c to
cb770cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds composable search and filter controls in the pad so you can narrow
the list without leaving Vim-style keybindings.
/— prompt for a case-insensitive text search (blank input clears)f— cycle done filter: all → pending → done → allF— cycle priority filter: all → high → medium → low → allT— today/overdue filter (unchanged; composes with the above)Active filters appear in the window title, e.g.
PinPad (today, pending, "fix").Filters reset when the pad closes.
Changes
sort.lua:PinPadViewFilterstate (today, query, done, priority);passes_filter,cycle_done,cycle_priority,filter_title_suffixui.lua: unified filter state; updated empty-state hintactions.lua/config.lua:/,f,Fmappingssort_spec.lua(+7 tests)Test plan
make testgreen (52 passed)/+ text — only matching tasks remain; title shows"query"fcycles pending/done;Fcycles priorityT+/+f— filters stack correctly