Fix music downloads and added a basic docker compose file for quick self hosting.#705
Open
b-hayes wants to merge 4 commits intoalexta69:masterfrom
Open
Fix music downloads and added a basic docker compose file for quick self hosting.#705b-hayes wants to merge 4 commits intoalexta69:masterfrom
b-hayes wants to merge 4 commits intoalexta69:masterfrom
Conversation
alexta69
reviewed
Jul 1, 2025
| return f"bestaudio[ext={format}]/bestaudio/best" | ||
| # Use a more robust format string that ensures audio-only download | ||
| # and has better fallbacks | ||
| return f"bestaudio[ext={format}]/bestaudio[ext=m4a]/bestaudio[ext=mp3]/bestaudio/best[ext!=webm]/best[ext!=webm]" |
| 'format': self.format, | ||
| 'socket_timeout': 30, | ||
| 'ignore_no_formats_error': True, | ||
| 'ignore_no_formats_error': False, # Changed to False to get better error messages |
Owner
There was a problem hiding this comment.
This was added in 74d07f5. Let's make sure that we're not introducing a regression
Comment on lines
+304
to
+310
| 'cookiefile': None, # Allow cookie usage if available | ||
| 'age_limit': None, # Don't restrict by age | ||
| 'geo_bypass': True, # Attempt to bypass geographic restrictions | ||
| 'geo_bypass_country': None, # Let yt-dlp choose the best bypass method | ||
| 'extractor_retries': 3, # Retry extraction up to 3 times | ||
| 'youtube_include_dash_manifest': True, # Include DASH formats for YouTube Music | ||
| 'youtube_skip_dash_manifest': False, # Don't skip DASH manifest |
Owner
There was a problem hiding this comment.
No reason for any of these changes that I'm seeing. Setting parameters to None is redundant. geo_bypass -- the user can set if they want to, no reason for us to force it. The same goes to the other non-None parameters here. Let's leave this out
| ytdl_options = dict(self.config.YTDL_OPTIONS) | ||
| if playlist_item_limit > 0: | ||
| log.info(f'playlist limit is set. Processing only first {playlist_item_limit} entries') | ||
| ytdl_options['playlistend'] = playlist_item_limit |
| @@ -0,0 +1,27 @@ | |||
| # MeTube - Self-hosted YouTube downloader with web UI | |||
| # This setup allows you to modify the code and see changes reflected in the running container | |||
Owner
There was a problem hiding this comment.
Let's call the file accordingly, docker-compose.yml suggests that this is a compose file for production use. We can call it docker-compose-dev-env.yml or something like that
Comment on lines
+16
to
+17
| - OUTPUT_TEMPLATE=%(artist,uploader)s/%(artist,uploader)s - %(title)s%(genre& [%s]|)s (%(release_date>%Y-%m-%d,upload_date>%Y-%m-%d)s).%(ext)s | ||
| - OUTPUT_TEMPLATE_PLAYLIST=%(playlist_title)s/%(artist,uploader)s - %(title)s%(genre& [%s]|)s (%(release_date>%Y-%m-%d,upload_date>%Y-%m-%d)s).%(ext)s |
Owner
There was a problem hiding this comment.
We have other defaults in the code, no reason for changing these defaults for development purposes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.