Open
Conversation
added 9 commits
March 2, 2023 10:56
jsimlo
requested changes
Mar 14, 2023
morf-oracle/src/main/java/org/alfasoftware/morf/jdbc/oracle/OracleDialect.java
Outdated
Show resolved
Hide resolved
morf-oracle/src/main/java/org/alfasoftware/morf/jdbc/oracle/OracleDialect.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
|
Alternative to #241 |
jsimlo
requested changes
Mar 23, 2023
| this.fields.clear(); | ||
| Iterables.addAll(this.fields, Builder.Helper.buildAll(fields)); | ||
| return castToChild(this); | ||
| } |
| } else { | ||
| fieldsToInclude.add(field); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
if (field instanceof NullFieldLiteral || field instanceof FieldReference)
I think we want to handle all fields, including expressions, etc.
So, basically, there should be no else in there.
| column("nullField", DataType.STRING, 3) | ||
| ).indexes( | ||
| index("SomeTable_1").columns("otherField") | ||
| ); |
Contributor
There was a problem hiding this comment.
Notice that this index is not present in the resulting SQL (which is correct and by design).
Indexes cannot be part of a CTAS, which is documented at SchemaEditor.addTableFrom(Table, SelectStatement).
Contributor
There was a problem hiding this comment.
Was this not possible to add as tests for all dialects?
Any advantage to have this as a separate test class?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug with CTAS, Oracle Dialect will now handle null values when creating a new table as select.