Refactor: Move generic code out of apple-crypto so other dimpl based crates can share the common code#904
Closed
efer-ms wants to merge 4 commits intoalgesten:mainfrom
Closed
Refactor: Move generic code out of apple-crypto so other dimpl based crates can share the common code#904efer-ms wants to merge 4 commits intoalgesten:mainfrom
efer-ms wants to merge 4 commits intoalgesten:mainfrom
Conversation
Owner
|
@efer-ms I realize now that we can make the prf and hkdf stuff impls once for all crypto providers in dimpl, and only have the I prepared a PR for that here: algesten/dimpl#94 - this also copies across the tests you made for this in the macro. The other part, making certificate generation without rcgen, is something that was also discussed on Discord. I am for that, and think we should make dimpl create certs without that dep, just relying on what we already have. I think this is a another PR in dimpl. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we were moving wincrypto to utilize dimpl, we saw lots of generic code that could be shared with Apple-crypto. I anticipate it will be the same with other dimpl cryptos.