Open
Conversation
raresluncan
reviewed
Oct 15, 2021
| - accounts/ | ||
| - components/ | ||
| - pages/ | ||
| - redux/ |
There was a problem hiding this comment.
Is this Redux folder needed if we have core redux and a redux file inside the component itself?
Author
There was a problem hiding this comment.
This should be the place where you define the actions/reducers/selectors for this specific feature folder. Not all of these are going to be implemented in the core folder because they can be feature-specific.
| TODO | ||
|
|
||
| # ??? | ||
| What else? |
There was a problem hiding this comment.
To define:
- subcomponents only used by one component
Author
There was a problem hiding this comment.
I'm not sure I understand what you mean.
|
|
||
| When they are defined as `js` file, the file name should end with `Style.js`. | ||
|
|
||
| In both cases, the file names should contain the component name and they should be `cameCased`. |
There was a problem hiding this comment.
For scss files how do you feel about MyComponent.style.scss?
Author
There was a problem hiding this comment.
I think that having the scss extension is obvious enough that it is a style file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.