Skip to content

Consolidate CI checks and configure EAS submit app ID - #22

Merged
alhaymex merged 1 commit into
mainfrom
feat/eas-config
May 2, 2026
Merged

Consolidate CI checks and configure EAS submit app ID#22
alhaymex merged 1 commit into
mainfrom
feat/eas-config

Conversation

@alhaymex

@alhaymex alhaymex commented May 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Consolidates the GitHub Actions CI workflow into a single checks job that runs formatting, linting, type checking, and tests in one place.
  • Removes duplicated setup steps from the previous separate CI jobs to simplify maintenance.
  • Adds the iOS ascAppId to apps/mobile/eas.json so EAS submit can target the correct App Store Connect app.

Testing

  • Not run (workflow and config-only changes).
  • Verified the CI workflow now runs pnpm format:check, pnpm lint, pnpm typecheck, and pnpm test in a single job.
  • Verified apps/mobile/eas.json includes submit.production.ios.ascAppId.

Summary by CodeRabbit

  • Chores
    • Optimized CI/CD workflow by consolidating multiple testing jobs into a single unified process, improving build efficiency.
    • Updated mobile app deployment configuration for iOS platform submission.

- Merge format, lint, typecheck, and test into one CI job
- Configure the iOS App Store Connect app ID for EAS submit
@coderabbitai

coderabbitai Bot commented May 2, 2026

Copy link
Copy Markdown
ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Free

Run ID: e9f35c5c-1f0f-42ca-8ae5-723bea1f1750

📥 Commits

Reviewing files that changed from the base of the PR and between 313261e and c8f8f23.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • apps/mobile/eas.json

📝 Walkthrough

Walkthrough

CI workflow jobs were consolidated: four separate jobs (format, lint, typecheck, test) were merged into a single checks job. Concurrently, the mobile EAS configuration was updated to include an iOS App Store Connect ID in the production submission settings.

Changes

CI Workflow Consolidation

Layer / File(s) Summary
Job Structure
.github/workflows/ci.yml
Job format renamed to checks; removes redundant job definitions for lint, typecheck, and test.
Unified Step Execution
.github/workflows/ci.yml
All checks (pnpm format:check, pnpm lint, pnpm typecheck, pnpm test) now run sequentially within the single checks job, eliminating duplicate setup and checkout steps.

Mobile EAS Configuration

Layer / File(s) Summary
Production Submission Config
apps/mobile/eas.json
submit.production updated from empty object to include ios.ascAppId: "6764123652" for App Store Connect submission.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Four jobs once danced, now one does it all,
Steps combine in sequence, answering the call.
CI flows tidier, duplication falls,
And App ID stands ready—production beckons and enthralls! 🚀


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Review rate limit: 1/3 review remaining, refill in 25 minutes and 6 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@alhaymex
alhaymex merged commit 6373035 into main May 2, 2026
2 checks passed
@alhaymex
alhaymex deleted the feat/eas-config branch May 2, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant