Skip to content

Fix convert.py: --global-index no longer requires --input-dir #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ali5ter merged 1 commit into from
Apr 13, 2026
Merged

Fix convert.py: --global-index no longer requires --input-dir #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ def main() -> None:
description="Convert archive PDFs (magazines, books) to searchable Markdown"
)
parser.add_argument("--analyze", action="store_true", help="Probe PDFs and report structure without converting")
parser.add_argument("--input-dir", type=Path, required=True, help="Source PDF directory")
parser.add_argument("--input-dir", type=Path, required=False, default=None, help="Source PDF directory")
parser.add_argument("--output-dir", type=Path, default=Path("converted"), help="Output directory (default: ./converted)")
parser.add_argument("--pattern", default="**/*.pdf", help="Glob pattern to select PDFs (default: **/*.pdf)")
parser.add_argument("--dpi", type=int, default=200, help="Page image render DPI (default: 200)")
Expand All @@ -604,6 +604,9 @@ def main() -> None:
write_global_index(args.global_index, output_path)
return

if not args.input_dir:
parser.error("--input-dir is required unless --global-index is specified")

if not args.input_dir.exists():
print(f"ERROR: Input directory not found: {args.input_dir}")
sys.exit(1)
Expand Down
Loading