Skip to content

chore(ci): bump umm-actually to v0.4.8 - #29

Merged
aliasunder merged 2 commits into
mainfrom
chore/bump-umm-actually-0.4.8
Sep 24, 2026
Merged

aliasunder merged 2 commits into
mainfrom
chore/bump-umm-actually-0.4.8

Conversation

@aliasunder

Copy link
Copy Markdown
Owner

Bumps the umm-actually review action pin from v0.4.7 to v0.4.8.

v0.4.8 changes:

  • Priority docs read first. Up to 10% of the context budget now goes to priority docs before changed files are read, so a large diff can no longer crowd them out.
  • Findings name their model. When phases route to different models, each finding's byline names the model that produced it.

No new inputs in this release, so the template changes only the pin.

🤖 Generated with Claude Code

@umm-actually

umm-actually Bot commented Sep 24, 2026

Copy link
Copy Markdown

Update context-budget priority-order comment for v0.4.8
Low severity · subtle bugs · high confidence

.github/workflows/umm_review.yml:133 — beyond the diff's line ranges, in code the changes touch or depend on.

The comment claims the shared token pool is spent in the order diff → changed files → import-traced related files → priority docs → mention-matched docs, but v0.4.8 reads priority docs first — up to 10% of the budget goes to them before changed files are read. The comment now misdescribes the action's behavior and misleads operators tuning context_budget_tokens or priority_docs.

Failure scenario: An operator reads the workflow comment and assumes priority docs are budgeted only after changed files are read; with v0.4.8 the action reserves up to 10% of the budget for priority docs before reading changed files, so the documented order no longer matches what the action does and the operator reasons from a wrong model when sizing context_budget_tokens.

Suggested fix
Reword to: 'One shared token pool for all prompt context, spent in priority order: diff → priority docs (up to 10% of budget, read before changed files) → changed files → import-traced related files → mention-matched docs. (Conventions file has its own separate cap inside the action.)'

umm-actually · deepseek/deepseek-v4-flash-0731

@umm-actually

umm-actually Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

umm-actually re-reviewed at b707444

No new findings (1 tracked finding(s) across all runs).


umm-actually · deepseek/deepseek-v4-flash-0731

@aliasunder

Copy link
Copy Markdown
Owner Author

Fixed in b707444. The comment now lists the v0.4.8 order: diff, then priority docs (up to 10% of the budget, read before changed files), then changed files, import-traced related files, any priority docs that didn't fit earlier, and mention-matched docs. The same template comment is fixed in the other five consumer bump PRs.

Posted by Claude Code

@aliasunder
aliasunder merged commit 6a393b4 into main Sep 24, 2026
7 checks passed
@aliasunder
aliasunder deleted the chore/bump-umm-actually-0.4.8 branch September 24, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant