feat(openrouter): tag client log lines with the review phase

[aliasunder]

Summary

With phases: parallel, three review phases call the same model at the same time. Until now, the OpenRouter client's log lines carried the model but no phase. A failed attempt, a fallback advance, or a request that settled after its deadline could not be tied to the phase that sent it. generationId only appears on accepted responses, so it doesn't help with failures.

Every line the client logs for a phase now carries phase: <id>. This includes the late-settlement line, which is logged after requestReview has already returned.

Changes

• src/openrouter/client.ts
  • requestReview(params, logger) takes the caller's logger, and createOpenRouterClient no longer takes one.
  • attemptOnce and lookupGenerationCost pass withDeadline a child of that logger. The child binds the operation (operation plus model or generationId), so withDeadline no longer takes a separate logContext record.
  • The cost-lookup failure warnings log through the same child, so they now carry generationId as well.
  • All nine log call sites write through the request's logger, or through a child of it that adds the operation's fields:
    • review attempt failed
    • advancing to fallback model without same-model retry
    • retrying with an output ceiling…
    • review response accepted
    • request deadline elapsed
    • deadline-elapsed request settled
    • generation cost lookup failed (two sites)
    • unexpected generation response shape
• src/orchestrate.ts
  • createPromptedGenerateFindings builds logger.child({ phase }) for each call and passes it to requestReview.
  • Its own requesting review line logs through the same phase logger. The hand-set module: "generateFindings" tag on that line is gone, because the auto-captured source field already names the file.
• src/main.ts: builds the client without a logger.

Tests

• Client tests: each requestReview call passes the same captured logger its assertions read.
• New client test: a caller-bound prop reaches deadline-elapsed request settled after the request has already rejected. The test also asserts the exact rejection message.
• New createPromptedGenerateFindings tests:
  • Two phases produce two client log entries, each with its own phase.
  • The requesting review line is asserted whole: phase, model, and fallbackModel.
• Cost-lookup tests: the warning assertions now include generationId.
• New parallel integration test with the real client:
  • The first-dispatched phase (correctness-security) fails once with a retryable 500.
  • Its review attempt failed line names that phase.
  • All three review response accepted lines name their own phase.
• Mutation checks, each run on a commit and reverted afterwards. The first three ran on ab4f290, and the last three ran after the logger-context refactor:

Mutation	Failing tests
Pass the unscoped logger instead of the phase child	Both new orchestrate tests
Store the per-call logger on the client, so the last caller wins	The parallel integration test: the failure line reads subtle-bugs
Log the late settlement through the module-level logger	The new client test and 3 existing late-settlement tests
Log requesting review through the unscoped logger	The requesting review test (missing phase)
Pass withDeadline the plain logger instead of the chat-request child	5 client deadline and late-settlement tests
Pass withDeadline the plain logger instead of the cost-lookup child	2 cost-lookup deadline tests

Verification

• npm test: 804 passed
• npm run lint and npm run build are clean, and docker build . succeeds.
• Live: this PR's self-review runs combined, and its log shows review response accepted with "phase":"combined" and "source":"client.js:…".

🤖 Generated with Claude Code

[umm-actually]

umm-actually re-reviewed at fec6d29

1 new finding(s) posted (1 tracked finding(s) across all runs).

---

umm-actually · deepseek/deepseek-v4.1-flash