Skip to content

fix(review): resolve escaped finding paths and drop findings on an excluded conventions file #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aliasunder merged 15 commits into from
Oct 1, 2026
Merged

fix(review): resolve escaped finding paths and drop findings on an excluded conventions file #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
33da03e
fix(review): keep findings whose file copies an escaped path attribute
aliasunder Sep 30, 2026
1d36e06
test(orchestrate): group the escaped-path posting test with the beyon…
aliasunder Sep 30, 2026
0fad946
docs(review): state that the attribute decoder is not a true inverse
aliasunder Sep 30, 2026
f0d5650
style: clear readability pauses in the unknown-file filter and its ca…
aliasunder Sep 30, 2026
5f04522
test(review): seed both sides of every unknown-file rule test
aliasunder Sep 30, 2026
e9dbfef
fix: correct the diff-header and full-copy claims in the escaped-path…
aliasunder Sep 30, 2026
6efc1d5
docs: clarify the unknown-file filter and name the filter summary log…
aliasunder Sep 30, 2026
faafef8
docs: state the overlap tie rule and the conventions-file exclusion e…
aliasunder Sep 30, 2026
db9ec9f
docs: scope the prompt-tag and dot-segment claims to what the code does
aliasunder Sep 30, 2026
d986264
test: seed dropped near-misses in the unknown-file filter tests
aliasunder Sep 30, 2026
62f3393
fix: drop findings on a diff-excluded conventions file
aliasunder Sep 30, 2026
e9e853e
test(orchestrate): cover a ./-prefixed excluded conventions file
aliasunder Sep 30, 2026
2753a2c
fix: report findings on diff-excluded files apart from unknown-file d…
aliasunder Sep 30, 2026
ab771a6
Merge origin/main into fix/resolve-escaped-finding-paths
aliasunder Sep 30, 2026
d8f0e40
test(orchestrate): post a decoded escaped changed-file finding inline
aliasunder Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 26 additions & 16 deletions README.md
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ inputs:

outputs:
findings_count:
description: Number of new findings posted this run. Non-findings, findings on files the model never saw, duplicates, findings already posted on an earlier run, and findings below `severity_threshold` are removed before `max_findings` applies; a finding whose post failed is not counted
description: Number of new findings posted this run. Non-findings, findings on files the model never saw or that diff exclusion removed, duplicates, findings already posted on an earlier run, and findings below `severity_threshold` are removed before `max_findings` applies; a finding whose post failed is not counted
review_url:
description: URL of the submitted review; empty when no review was posted
model_used:
Expand Down
Loading
Loading