feat: feed prior bot comments to model for conceptual dedup by aliasunder · Pull Request #27 · aliasunder/umm-actually

aliasunder · 2026-07-22T23:28:32Z

Summary

Cross-run dedup uses file:category:line keys with a ±5 line proximity window, which misses conceptual duplicates — findings with the same underlying premise but anchored at different lines (e.g. PR feat: doc-staleness context — mention-based reverse-reference scan #10: false symlink premise raised 3× at lines 183, 219, 336)
Feed existing bot comment bodies to the model via a new prior_bot_comments prompt section so it self-suppresses known issues at the semantic level — handles paraphrases that no lexical similarity measure would catch
Refactored fetchInlineAnchors → fetchInlineCommentState to preserve raw comment bodies alongside anchors; extended fetchIssueCommentState to return finding bodies (status comment excluded); strip dedup anchor HTML before prompt inclusion; cap at 30

Test plan

🤖 Generated with Claude Code

Summary by CodeRabbit

New Features
- Improved review generation across repeated runs by providing previous bot comments as context.
- Prior comments are filtered, deduplicated, limited to the most recent entries, and clearly separated from status updates.
- Review prompts now instruct the system not to re-report findings already covered by earlier bot comments.
Tests
- Added coverage for first-run behavior, comment limits, status-comment exclusion, anchor removal, and prompt formatting.

Cross-run dedup uses file:category:line keys with a ±5 line proximity window — this misses conceptual duplicates at distant lines (same premise, 100+ lines apart). Feed existing bot comment bodies to the model via a new prior_bot_comments prompt section so it self-suppresses known issues at the semantic level. - Refactor fetchInlineAnchors → fetchInlineCommentState to preserve raw comment bodies alongside anchors - Extend fetchIssueCommentState to return finding bodies (status comment excluded) - Strip dedup anchor HTML before including in prompt - Cap at 30 most recent comments to bound token usage - Add priorBotComments to ReviewContext, flows through to buildUserPrompt - 7 new tests: body passthrough, anchor stripping, status exclusion, cap enforcement, first-run empty case, prompt rendering + ordering Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

umm-actually · 2026-07-22T23:31:44Z

umm-actually re-reviewed at a23ed30

1 new finding(s) posted (3 tracked finding(s) across all runs).

umm-actually · deepseek/deepseek-v4-pro

aliasunder · 2026-07-22T23:41:05Z

@CodeRabbit review

coderabbitai · 2026-07-22T23:41:09Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-07-22T23:46:26Z

📝 Walkthrough

Walkthrough

Changes

Prior bot comment context

Layer / File(s)	Summary
Comment state collection `src/orchestrate.ts`	Prior inline and issue comment state now includes finding bodies, status classification, anchors, and anchor-stripped comment content.
Orchestration context and dedup integration `src/orchestrate.ts`	Prior bot comments are combined, normalized, capped at 30 entries, passed to finding generation, and reused for cross-run anchor deduplication.
Prior comment prompt rendering `src/review/prompt.ts`	Prompt generation conditionally adds prior bot comments between the diff and prior findings sections.
Orchestration and prompt coverage `src/__tests__/orchestrate.test.ts`, `src/review/__tests__/prompt.test.ts`	Tests cover comment sourcing, normalization, status exclusion, capping, first-run behavior, rendering, ordering, and updated context fixtures.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

aliasunder/umm-actually#8: Updates the cross-run deduplication flow for prior review and issue comments.
aliasunder/umm-actually#12: Refactors bot comment fetching and deduplication state in orchestration.
aliasunder/umm-actually#10: Extends prompt assembly with an additional context section.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly captures the main change: sending prior bot comments to the model for conceptual deduplication.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch worktree-conceptual-dedup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/__tests__/orchestrate.test.ts`:
- Around line 1713-1715: Update the test around priorBotCommentsFrom to assert
the complete retained comments array, matching the exact sequence from “finding
10” through “finding 39” in order, rather than checking only its length and
final entry.

In `@src/orchestrate.ts`:
- Around line 429-434: Update the data retrieval used by priorBotComments so
both inline and issue comment client methods return creation timestamps
alongside bodies; merge the two collections chronologically, sort by those
timestamps, then apply PRIOR_COMMENT_CAP before stripping anchors, preserving
the 30 most recent comments regardless of source.
- Around line 429-434: Update the prior-comment assembly around priorBotComments
to enforce an explicit token budget in addition to PRIOR_COMMENT_CAP. After
stripAnchorComment, retain comments newest-first and truncate or stop before the
cumulative token count exceeds the reserved budget, ensuring the bounded content
is what gets appended after context-budget calculation.

In `@src/review/__tests__/prompt.test.ts`:
- Around line 307-313: Update the test around userPrompt to assert the complete
deterministic prior-bot-comments section as one exact rendered block, including
the opening tag with its note attribute, both comment bodies, the delimiter, and
the closing tag; replace the separate toContain assertions for these fragments
while preserving any unrelated prompt assertions.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d031e75b-88fc-4b53-8a5d-e45868a883e9

📥 Commits

Reviewing files that changed from the base of the PR and between a1c2f49 and 88c9273.

📒 Files selected for processing (4)

src/__tests__/orchestrate.test.ts
src/orchestrate.ts
src/review/__tests__/prompt.test.ts
src/review/prompt.ts

… sections Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…tion Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Full-result toEqual on all selectFindings tests (was decomposed property picks that missed droppedAsOverlapping/droppedByCap fields). Collapse 4 fragment toContain calls in the prior-bot-comments prompt test into one full-section assertion. Add pipe-escaping coverage for renderPaths — the only production behavior with no test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…oc, outputs table - AGENTS.md: review/ structure tree now includes filter-non-findings.ts (listed as "non-finding filter") - prompt.ts: buildUserPrompt JSDoc now enumerates the prior-bot-comments and prior-findings sections that follow the diff - README.md: findings_count output description now mentions the non-finding filter stage Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

umm-actually · 2026-07-23T01:19:22Z

      anchors: extractAnchors(
-        comments.map((comment) => ({
+        findingComments.map((comment) => ({
          body: comment.body,
          line: null,
          originalLine: null,
        })),
      ),
+      findingBodies: findingComments.map((comment) => comment.body),


[low/correctness] Collect findingBodies only from anchored comments in fetchIssueCommentState (confidence: low)

findingBodies is derived from findingComments, which includes any non-status comment regardless of whether it contains a valid anchor. A bot comment that is not a status comment and lacks an anchor would still appear in priorBotComments, polluting the prompt with non-finding text.

Failure scenario: A bot posts a standalone PR comment that does not start with STATUS_ANCHOR and lacks a hidden anchor (e.g., a follow-up note or a future non-finding comment). The comment body is included in priorBotComments, wasting context and potentially confusing the model's conceptual dedup.

Suggested fix

Derive findingBodies only from comments that extractAnchors successfully parses, or filter comments to those containing the anchor pattern before mapping.

coderabbitai Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread src/__tests__/orchestrate.test.ts Outdated

Comment thread src/orchestrate.ts

Comment thread src/review/__tests__/prompt.test.ts

aliasunder and others added 3 commits July 22, 2026 19:53

fix(review): document conceptual dedup in README pipeline and shipped…

4fd9170

… sections Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

style: rename pathList to renderPaths, add summary to review/ descrip…

17c997f

…tion Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

umm-actually Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread src/orchestrate.ts

Comment thread src/orchestrate.ts

aliasunder and others added 3 commits July 22, 2026 20:17

test: assert complete capped prior-comments array

0dc4d67

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

docs: add JSDoc to PRIOR_COMMENT_CAP constant

a23ed30

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

aliasunder merged commit 62383ec into main Jul 23, 2026
8 checks passed

umm-actually Bot reviewed Jul 23, 2026

View reviewed changes

aliasunder deleted the worktree-conceptual-dedup branch July 25, 2026 18:32

Navigation Menu

Repository navigation

feat: feed prior bot comments to model for conceptual dedup - #27

feat: feed prior bot comments to model for conceptual dedup#27
aliasunder merged 7 commits into
mainfrom
worktree-conceptual-dedup

aliasunder commented Jul 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

umm-actually Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

aliasunder commented Jul 22, 2026

Uh oh!

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 22, 2026

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

umm-actually Bot Jul 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

aliasunder commented Jul 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

umm-actually Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aliasunder commented Jul 22, 2026

Uh oh!

coderabbitai Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 22, 2026

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

umm-actually Bot Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

aliasunder commented Jul 22, 2026 •

edited by coderabbitai Bot

Loading

umm-actually Bot commented Jul 22, 2026 •

edited

Loading

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading