Skip to content

docs: cross-link vault-onboarding companion skill; add pkm keywords #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aliasunder wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

docs: cross-link vault-onboarding companion skill; add pkm keywords #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
fa38a30
docs: cross-link vault-onboarding companion skill; add pkm keywords
aliasunder Aug 6, 2026
fc12b31
chore: add pkm keywords to CLI package
aliasunder Aug 6, 2026
3b652b7
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Aug 7, 2026
9047680
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Aug 8, 2026
d2fed3b
Merge origin/main into docs/vault-onboarding-crosslink (resolve keywo…
aliasunder Aug 14, 2026
d4ba167
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Aug 15, 2026
cba6f63
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Aug 15, 2026
56353bf
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Aug 18, 2026
cfc8dc2
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Aug 18, 2026
ccdec8d
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Aug 19, 2026
ddb4dd2
Merge remote-tracking branch 'origin/main' into docs/vault-onboarding…
aliasunder Aug 31, 2026
78cbc2b
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Sep 2, 2026
0e0d8a1
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Sep 11, 2026
31f5609
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Sep 15, 2026
2bda35a
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Sep 16, 2026
3682486
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Sep 25, 2026
0caae21
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Sep 30, 2026
798e8b3
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Oct 1, 2026
c20660a
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Oct 6, 2026
2723991
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Oct 21, 2026
5732565
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,16 @@ npx skills add aliasunder/agent-skills --skill obsidian-vault

[Skill source →](https://github.com/aliasunder/agent-skills/tree/main/skills/obsidian-vault)

## Companion: vault-onboarding skill

Starting from scratch? The **vault-onboarding** skill bootstraps the collaboration system this server powers — memory files, session protocols, task boards, and per-client instruction files — through a conversational interview. It works standalone with native file tools; connected to vault-cortex, the generated setup unlocks remote access, hybrid search, and semantic memory recall.

@umm-actually umm-actually Bot Oct 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qualify the README's claim that connecting unlocks semantic memory recall
Low severity · subtle bugs · medium confidence

The new companion section states unconditionally that connecting to vault-cortex lets the generated setup unlock hybrid search and semantic memory recall, but per AGENTS.md the vector stage of hybrid search is gated behind EMBEDDING_ENABLED and the memory layer behind its own feature flag, so a default deployment connected to vault-cortex provides keyword search only and no semantic recall.

Failure scenario: An Obsidian user reads the README companion section, installs vault-onboarding, connects the generated setup to a default vault-cortex deployment with EMBEDDING_ENABLED unset and memory tools disabled, and finds no semantic memory recall or vector search despite the README promising both unconditionally.

Suggested fix 
Condition the sentence, e.g. "…unlocks remote access and hybrid search (semantic recall when embedding is enabled)", or note the two env vars that enable the vector and memory layers.

umm-actually · z-ai/glm-5.3-flash


```bash
npx skills add aliasunder/vault-onboarding
```

[Skill source →](https://github.com/aliasunder/vault-onboarding)

---

## Roadmap
Expand Down
1 change: 1 addition & 0 deletions cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"ai-memory-system",
"knowledge-base",
"note-taking",
"second-brain",
"pkm",
"personal-knowledge-management",
Comment on lines +38 to 40

@umm-actually umm-actually Bot Aug 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align PR description with the actual keyword change
Low severity · subtle bugs · high confidence

The PR description claims package.json keywords were changed as attachments → pkm + personal-knowledge-management (kept pdf), but the diff only adds second-brain to cli/package.json; attachments remains in the list and pkm/personal-knowledge-management were already present before this PR.

Failure scenario: A maintainer relying on the PR description to review the keyword change believes attachments was removed from the published npm package's keywords, but it is still shipped, so the LobeHub listing (generated from these keywords post-merge) still advertises attachments while the description claimed otherwise.

Suggested fix 
Update the PR description to state that `second-brain` was added to align cli/package.json keywords with the root package.json and GitHub topics, and that `attachments` was retained.

"hybrid-search",
Expand Down
1 change: 1 addition & 0 deletions scripts/generate-dockerhub-readme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ const EXCLUDED_H2 = new Set([
"Authentication",
"Development",
"Companion: obsidian-vault skill",
"Companion: vault-onboarding skill",
"Contributing",
"Security",
"Roadmap",
Expand Down
Loading