Skip to content

docs: bust CI badge cache - #632

Merged
aliasunder merged 2 commits into
mainfrom
docs/ci-badge-cache-bust-20261001
Oct 1, 2026
Merged

aliasunder merged 2 commits into
mainfrom
docs/ci-badge-cache-bust-20261001

Conversation

@aliasunder

@aliasunder aliasunder commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

What does this PR do?

Adds v=1 to the CI badge image URL in README.md and its generated Docker Hub copy so Shields.io and GitHub's image proxy fetch a new cache entry. This follows the version parameter pattern used by the Gitleaks and Trivy badges.

Type of change

  • Documentation

Validation

Ran the repository's Docker Hub README generator. Verified that the diff changes only the CI badge image URL on one line in each file, and read back both committed files to confirm the exact content. The branch filter, workflow link, and 12-hour cache duration are preserved.

Checklist

  • npm test passes
  • npm run lint passes
  • npm run prettier:check passes
  • npm run build succeeds

GitHub Actions CI passed for commit 113df922a7374d5acf425bc3e1b7a460d379c15b.

@umm-actually

umm-actually Bot commented Oct 1, 2026

Copy link
Copy Markdown

Regenerate DOCKERHUB.md to carry the v=1 CI badge cache-bust
Low severity · correctness · high confidence

DOCKERHUB.md:9 — beyond the diff's line ranges, in code the changes touch or depend on.

DOCKERHUB.md is auto-generated from README.md and mirrors the badges block verbatim, so after this edit the generated copy's CI badge URL no longer matches README.md's. The Docker Hub rendering of the README keeps the un-busted badge URL this PR is meant to refresh, and the generated file sits out of sync with its source until a future regeneration mixes this badge change into an unrelated diff.

Failure scenario: Committed state after this PR: README.md's CI badge URL ends in &v=1 while DOCKERHUB.md's does not. A visitor of hub.docker.com/r/aliasunder/vault-cortex gets the README copy whose CI badge URL lacks the cache-bust, so the stale badge entry this PR busts on GitHub survives on Docker Hub; the next regen of DOCKERHUB.md for other content silently carries the badge change in its diff.

Suggested fix
Run `npm run generate:dockerhub-readme` and commit the regenerated DOCKERHUB.md in this PR so the mirrored badges block matches README.md (CI badge with `&v=1`).

umm-actually · z-ai/glm-5.3-flash

@umm-actually

umm-actually Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

umm-actually re-reviewed at 113df92

No new findings (1 tracked finding(s) across all runs).

Context notes
  • Priority docs already in context: README.md

umm-actually · z-ai/glm-5.3-flash

Copy link
Copy Markdown
Owner Author

Fixed the generated Docker Hub README in 113df92. Ran the repository generator and verified that its output changes only the CI badge URL to include &v=1; both README copies now match.

@aliasunder
aliasunder merged commit cdbf8d8 into main Oct 1, 2026
18 checks passed
@aliasunder
aliasunder deleted the docs/ci-badge-cache-bust-20261001 branch October 1, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant