Skip to content

chore(ci): bump umm-actually to v0.4.8 - #34

Merged
aliasunder merged 2 commits into
mainfrom
chore/bump-umm-actually-0.4.8
Sep 24, 2026
Merged

aliasunder merged 2 commits into
mainfrom
chore/bump-umm-actually-0.4.8

Conversation

@aliasunder

Copy link
Copy Markdown
Owner

Bumps the umm-actually review action pin from v0.4.7 to v0.4.8.

v0.4.8 changes:

  • Priority docs read first. Up to 10% of the context budget now goes to priority docs before changed files are read, so a large diff can no longer crowd them out.
  • Findings name their model. When phases route to different models, each finding's byline names the model that produced it.

No new inputs in this release, so the template changes only the pin.

🤖 Generated with Claude Code

@umm-actually

umm-actually Bot commented Sep 24, 2026

Copy link
Copy Markdown

Update budget-order comment for v0.4.8 priority-docs-first behavior
Low severity · conventions · high confidence

.github/workflows/umm_review.yml:132 — beyond the diff's line ranges, in code the changes touch or depend on.

The comment says the shared token pool is spent 'diff → changed files → import-traced related files → priority docs → mention-matched docs,' but this bump moves priority docs ahead of changed files with up to 10% of the budget reserved for them. The stale ordering misleads anyone tuning context_budget_tokens or priority_docs, and the repo conventions require docs to update in the same change that alters behavior.

Failure scenario: A maintainer reads the comment while tuning vars.UMM_CONTEXT_BUDGET_TOKENS and decides to raise the budget because they believe README.md (priority_docs) receives only leftover tokens after the diff and changed files and can be crowded out — but v0.4.8 already guarantees it up-front, so the tuning decision rests on a false ordering the comment still documents.

Suggested fix
Reword the comment to the v0.4.8 order, e.g.: 'One shared token pool for all prompt context: priority docs reserve up to 10% of the budget and are read first, then diff → changed files → import-traced related files → mention-matched docs. (Conventions file has its own separate cap inside the action.)'

umm-actually · deepseek/deepseek-v4-flash-0731

@umm-actually

umm-actually Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

umm-actually re-reviewed at 8ca968d

No new findings (1 tracked finding(s) across all runs).


umm-actually · deepseek/deepseek-v4-flash-0731

@aliasunder

Copy link
Copy Markdown
Owner Author

Fixed in 8ca968d. The comment now lists the v0.4.8 order: diff, then priority docs (up to 10% of the budget, read before changed files), then changed files, import-traced related files, any priority docs that didn't fit earlier, and mention-matched docs. The same template comment is fixed in the other five consumer bump PRs.

Posted by Claude Code

@aliasunder
aliasunder merged commit 9cbf5a5 into main Sep 24, 2026
9 checks passed
@aliasunder
aliasunder deleted the chore/bump-umm-actually-0.4.8 branch September 24, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant