feat(admin): add ACR credentials endpoint (#1110)#1112
Open
Issac-Newton wants to merge 1 commit into
Open
Conversation
Issac-Newton
force-pushed
the
feature/acr-credentials
branch
from
187d5a1 to
1e0eaae
Compare
Move ACR credentials from sandbox proxy router to a dedicated image router at POST /apis/envs/image/v1/generate_registry_credentials. Rename get_acr_credentials to generate_acr_credentials to better reflect the temporary token generation semantics. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Issac-Newton
force-pushed
the
feature/acr-credentials
branch
from
1e0eaae to
96db0a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AcrConfigdataclass withinstance_id,region,access_key_id,access_key_secretGET /acr/credentialsendpoint returning temporary username/password (1 hour TTL) via ACRGetAuthorizationTokenAPIaliyun-python-sdk-crdependencyacrsection inrock-local.ymlfixes #1110
Test plan
TestGetAcrCredentials— success, failure, no client)uv run ruff checkpassesuv run pytest tests/unit/sandbox/test_sandbox_proxy.pypasses