fix(sec-core): complete skill-ledger status help - #2707
Open
jfeng18 wants to merge 1 commit into
Open
Conversation
![qoderai[bot]](https://avatars.githubusercontent.com/in/1396158?s=60&v=4){kind=small}
There was a problem hiding this comment.
本次改动主要补齐 skill-ledger 与 check 子命令的状态帮助文本，并新增帮助契约测试。整体实现与 issue 描述及现有行为对齐，未发现功能或安全问题。以下为三点细节建议，均为 P2 级别，可按需采纳：
check的 error JSON 测试示例目前绑定到缺失目录文案，未来扩展错误类型时可能增加演进成本，可改为只校验结构而不依赖具体提示字符串。_status_line_prefix将状态标签按 9 字符左对齐视为格式契约，建议在测试中简要说明该约定或改为更宽松的匹配以降低对 CLI 文本布局的耦合。cmd_check的 error 文案中“this object”略显抽象，可考虑明确返回 JSON 至少包含status与error字段，以便用户和 Agent 正确解析错误结果。
🤖 Generated by Qoder • View workflow run
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e0a0eec7d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The app-level integrity status list omitted unmanaged and error, and check help omitted error. List all eight verdicts from _VERDICT_SEVERITY, document when each status is produced, and add a help-contract test that matches statuses layout-independently. Closes #2656 Assisted-by: Qoder Signed-off-by: Jiangtian Feng <jiangtianf97@163.com>
jfeng18
force-pushed
the
fix/sec-core/ledger-help-statuses
branch
from
August 21, 2026 02:47
8e0a0ee to
d085ce5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The app-level integrity status list in
skill-ledger --helpomittedunmanagedanderror, andcheck --helpomittederror, so the documented status vocabulary drifted from the actual_VERDICT_SEVERITYverdicts. Readers could not tell from help output which statuses exist or when each one is produced.What changed
_VERDICT_SEVERITYand documents when each status is produced.check --helperror semantics calibrated against observed behavior: a failed single check prints{"status":"error"}and exits 1, while--allrecords the error as a per-entry item and continues.--help.Related issue
closes #2656
User / Agent impact
Help output only; no change to ledger evaluation, exit codes, or JSON output.
Risk and compatibility
Only the CLI help text changed (status vocabulary completed); zero runtime behavior change.
Validation
Documentation and rollback
The change itself is the documentation correction; no separate docs update needed. Single commit — revert it directly.