Skip to content

ci: update node version #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stay-foolish-forever wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −5
Open

ci: update node version #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57ffadd
ci: update node version used by github actions to 24
stay-foolish-forever Jun 26, 2026
51d2dc0
doc: remove uselsess comment
stay-foolish-forever Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/deploy-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
build:
runs-on: self-hosted
container:
image: node:20
image: node:24

@github-actions github-actions Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reliability concern: node:24 is a non-LTS (Current) release line. For production CI/CD workflows, it's recommended to use an LTS version (e.g., node:22 which should be the Active LTS around this time). Non-LTS releases have shorter support windows and may receive breaking changes more frequently.

Additionally, consider pinning to a more specific version tag (e.g., node:24.x.y) rather than just the major version to ensure reproducible builds. The node:24 tag will silently update on every minor/patch release, which could cause unexpected build failures.

Suggestion:

Suggested change
image: node:24
image: node:22

steps:
- uses: actions/checkout@v4

Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
url: ${{ steps.deployment.outputs.page_url }}
runs-on: self-hosted
container:
image: node:20
image: node:24
needs: build
steps:
- name: Deploy to GitHub Pages
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/ocr-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#
# Triggers:
# - PR opened (uses pull_request_target for fork secret access)
# - Comment on PR containing '/open-code-review' or '@open-code-review'
#
# Required secrets:
# OCR_LLM_URL - LLM API endpoint (e.g., https://api.openai.com/v1/chat/completions)
Expand Down Expand Up @@ -63,7 +62,7 @@ jobs:
code-review:
runs-on: self-hosted
container:
image: node:20
image: node:24

@github-actions github-actions Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Container image tag precision: Using a bare major version tag (node:24) means the underlying image can change silently when new minor/patch releases are published, potentially introducing breaking changes or inconsistencies between runs. Consider pinning to a specific minor or patch version (e.g., node:24.1 or node:24.1.0) for more reproducible builds, especially on self-hosted runners where image caching behavior may vary.

if: github.event_name == 'pull_request_target'
steps:
- name: Checkout repository
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ jobs:
needs: release
runs-on: self-hosted
container:
image: node:20
image: node:24

@github-actions github-actions Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential stability concern: Node.js 24 is likely still in "Current" (non-LTS) status as of now. For a release/publish workflow, using a non-LTS Node version may introduce unexpected breaking changes or instability. Consider using node:22 (the active LTS) instead, or if Node 24 is specifically required, pin to a specific minor version (e.g., node:24.1) to ensure reproducible builds.

Also note that this same change is applied consistently across deploy-pages.yml and ocr-review.yml, so any compatibility issue will affect all three workflows.

permissions:
contents: read
steps:
Expand Down
Loading