feat: add GPU buffer loader for IndexProvider integration#175
Closed
cluster2600 wants to merge 31 commits intoalibaba:mainfrom
Closed
feat: add GPU buffer loader for IndexProvider integration#175cluster2600 wants to merge 31 commits intoalibaba:mainfrom
cluster2600 wants to merge 31 commits intoalibaba:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpu_buffer_loader.h): streams vectors from anyIndexProviderinto contiguous GPU-ready float32 buffersdocs/METAL_CPP.md): architecture overview and kernel referenceReplaces #174 (now closed), which incorrectly used a standalone RocksDB store. This PR integrates with zvec's existing storage architecture via
IndexProvider::Iterator.Follow-up to #166 ("Future Work: Integration with storage").
How it works
Features
load()— stream all vectors into a single contiguous bufferload_chunk()— chunked loading for datasets exceeding GPU memoryWhy not RocksDB?
zvec already has a complete storage stack:
IndexProvider->Iterator-> block-based segments with mmap/buffer pool backends. A parallel RocksDB store would duplicate this.GpuBufferLoadersits on top of the existing pipeline instead.Merge order
Test plan
IndexProvider/IndexHolder::Iteratorinterfaces