Simplify custom adapter interface#86
Draft
adamzaninovich wants to merge 2 commits intoa2-rearchitecturefrom
Draft
Simplify custom adapter interface#86adamzaninovich wants to merge 2 commits intoa2-rearchitecturefrom
adamzaninovich wants to merge 2 commits intoa2-rearchitecturefrom
Conversation
adamzaninovich
commented
Sep 13, 2017
| def handle_cast({:reply, msg}, bot) do | ||
| IO.puts "got reply message #{inspect msg} from bot #{inspect bot}" | ||
| {:noreply, bot} | ||
| def handle_connect(bot) do |
Member
Author
There was a problem hiding this comment.
this should be handle_connected
Member
Author
There was a problem hiding this comment.
I changed my mind... this should be handle_connect
It makes more sense in the context of everything else.
adamzaninovich
commented
Jan 27, 2018
| @@ -1,39 +1,40 @@ | |||
| defmodule Alice.Adapters.ConsoleTest do | |||
Member
Author
There was a problem hiding this comment.
Still todo: make these tests work.
Member
Author
|
When the bot process crashes, it restarts. When it restarts, it also starts new adapter and handler processes, even though there are existing ones. Solution is probably to make sure old adapter and handlers are cleaned up when the bot crashes so that an entirely new system can be started. |
adamzaninovich
changed the title
Member
|
@adamzaninovich I'm working on review this, it's only taking me a few years :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tielur says making adapters is too damn hard.
I agree.
Hopefully this will fix that problem.
Still rough/not yet working. I'm pushing it up to get some eyes on it.