Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_until(b"aab")misses the delimiter inb"aaab": after the thirda, the current fallback keeps progress 1 instead of 2. This change retains the longest matching prefix suffix, so the followingbcompletes the match. It also fixesb"abac"inb"ababac".Related: #1. Submitted as a draft for review and import into the internal tree, following CONTRIBUTING.md.
The generator considers fallback lengths in descending order, emits only the longest state for each next-byte value, and skips the byte already handled by the normal match branch. This avoids the bytecode expansion found in an earlier unsubmitted candidate. Whole-delimiter overlap rejection and the timeout/max paths remain unchanged; generated drivers are untouched.
Validation against released base
8fd8135e8781aeacbbb7939b94f09cec96e44386:pip install -e '.[cyphal]'andnxs --versionpassed (nxs 1.1.0) in an isolated environment.bytes.find.a5 5a, and CRLF programs remain byte-identical. Existing invalid-delimiter rejection was preserved.The private VM tests, hardware, asynchronous byte arrival, and full driver deployment were not tested. Some 96/128-byte programs exceed 4,096 bytes in both versions; successful emitter construction is not a deployment claim. Please port the small fixtures to the internal regression suite and review the full program budget before accepting.
Prepared for ERDI TECH LTD with AI-assisted source analysis, implementation, and independent review. No ERDI hardware integration or commercial compatibility is claimed.