refactor(test): improve ProtocolVersions test coverage and quality#6
Open
refactor(test): improve ProtocolVersions test coverage and quality#6
Conversation
- add bounds to fuzz tests for realistic protocol version ranges - add test for version() function coverage - reorganize test contracts to match source function declaration order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(test): improve ProtocolVersions test coverage and quality
Summary
Enhanced the ProtocolVersions test suite following established testing guidelines:
bound(_version, 0, type(uint128).max)totestFuzz_setRequired_succeedsandtestFuzz_setRecommended_succeedsfor more realistic testing rangesProtocolVersions_Version_Testcontract to test theversion()function that was previously untestedAll tests pass including heavy fuzz testing with 20,000 runs each.
Review & Testing Checklist for Human
type(uint128).maxupper bound aligns with actual protocol version values used in deploy configs (e.g., mainnet uses0x0000000000000000000000000000000000000003000000010000000000000000)just test-dev --match-path test/L1/ProtocolVersions.t.sol -vto ensure no regressionsversion()getter functionNotes