Skip to content

refactor(test): improve ProtocolVersions test coverage and quality #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aliersh wants to merge 2 commits into
base: develop
Choose a base branch
from
+4 −0
Open

refactor(test): improve ProtocolVersions test coverage and quality #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e509832
refactor(test): improve ProtocolVersions test coverage and quality
devin-ai-integration[bot] Sep 4, 2025
0d62496
fix: format ProtocolVersions test file
devin-ai-integration[bot] Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/contracts-bedrock/test/L1/ProtocolVersions.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ contract ProtocolVersions_Initialize_Test is ProtocolVersions_TestInit {
contract ProtocolVersions_SetRequired_Test is ProtocolVersions_TestInit {
/// @notice Tests that `setRequired` updates the required protocol version successfully.
function testFuzz_setRequired_succeeds(uint256 _version) external {
_version = bound(_version, 0, type(uint256).max);

vm.expectEmit(true, true, true, true);
emit ConfigUpdate(0, IProtocolVersions.UpdateType.REQUIRED_PROTOCOL_VERSION, abi.encode(_version));

Expand All @@ -97,6 +99,8 @@ contract ProtocolVersions_SetRequired_Test is ProtocolVersions_TestInit {
contract ProtocolVersions_SetRecommended_Test is ProtocolVersions_TestInit {
/// @notice Tests that `setRecommended` updates the recommended protocol version successfully.
function testFuzz_setRecommended_succeeds(uint256 _version) external {
_version = bound(_version, 0, type(uint256).max);

vm.expectEmit(true, true, true, true);
emit ConfigUpdate(0, IProtocolVersions.UpdateType.RECOMMENDED_PROTOCOL_VERSION, abi.encode(_version));

Expand Down