Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100
Acceptance criterion (verbatim):
What changed
src/pycharting/core/server.py: removed the module-levellogging.basicConfig(level=logging.INFO, ...). A plainimport pychartingno longer adds a handler to the root logger or changes its level, so it can't override the logging setup of whatever app imports it.tests/pycharting/core/test_server.py: addedtest_import_leaves_root_logging_unconfigured. It runs the criterion's exact command in a fresh interpreter, because pytest attaches its own capture handlers to the root logger and an in-process check would never see[].Gates
make fmt: passmake test: pass, 179 tests, 100% coverage (bar is 90%)[]Deliberately not addressed. The issue's optional suggestions are not in this PR: attaching a
NullHandlerto thepychartinglogger ("if default output is wanted"), and adding logging config todemo.pyor toserver.py's__main__block. The criterion doesn't need either.uvicorn.run(..., log_level="info")still configures uvicorn's own server logs when you run the server directly.Closes #100
🤖 Generated with Claude Code