Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
Updates a lifecycle test to be compatible with newer FastAPI behavior where include_router appends an _IncludedRouter marker object (without a path attribute) into app.routes, preventing an AttributeError during route inspection.
Changes:
- Avoids direct
route.pathaccess intest_websocket_endpoint_addedby usinggetattr(route, "path", None)when collecting route paths. - Adds an explanatory comment documenting why the guard is needed for newer FastAPI versions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tschm
force-pushed
the
fix-included-router-route-path
branch
from
July 20, 2026 07:21
2107521 to
ba1b49a
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI test
test_websocket_endpoint_addedfailed withAttributeError: '_IncludedRouter' object has no attribute 'path'.Newer FastAPI versions append an
_IncludedRoutermarker object toapp.routeswheninclude_routeris called. That object has nopathattribute, so the route lookup in the test crashed.Fix
Guard the attribute access with
getattr(route, "path", None), skipping marker objects while still finding the/ws/heartbeatroute. This is a test-only change; no production code affected.🤖 Generated with Claude Code