Skip to content

feat(adk.sessions.v1): added display name to file data #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndrewMurdoch-Alis wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(adk.sessions.v1): added display name to file data #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cdb49e
feat(adk.sessions.v1): added display name to file data
AndrewMurdoch-Alis Jun 10, 2026
e5a2f14
fix(adk.sessions.v1): fixed spelling mistake
AndrewMurdoch-Alis Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions alis/adk/sessions/v1/sessions.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,9 @@ message FileData {

// Required. URI.
string file_uri = 2;

// Optional: the display name of the files
string display_name = 3;
Comment on lines +482 to +483

@gemini-code-assist gemini-code-assist Bot Jun 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment style and grammar should be consistent with the rest of the file. Specifically, use a period instead of a colon after 'Optional', capitalize the description, and use the singular 'file' instead of 'files' since FileData represents a single file.

Suggested change
// Optional: the display name of the files
string display_name = 3;
// Optional. Display name of the file.
string display_name = 3;

}

// VideoMetadata describes the input video content.
Expand Down